lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3706) Ship setup to log with log4j.
Date Thu, 28 Mar 2013 00:35:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615925#comment-13615925
] 

Shawn Heisey commented on SOLR-3706:
------------------------------------

A couple of notes after taking a look at things:

1) Included in example/lib/ext is jul-to-slf4j.jar, but I don't have this jar in my custom
log4j setup.  This might be because I do not use any features that depend directly on JUL.
 Searching the entire checkout for java.util.logging, I can see some explicit imports, even
outside the admin UI classes specifically made for it.  Below is a list of all the .java files
in trunk that import JUL classes.  I suspect that the spatial and facet code should use slf4j
instead.  The test code might have a legitimate reason to import JUL directly, and the log
formatter for the admin UI might still have need for it.  Is there anything here that needs
follow-up?

{noformat}
./lucene/spatial/src/test/org/apache/lucene/spatial/StrategyTestCase.java
./lucene/spatial/src/java/org/apache/lucene/spatial/util/ShapeFieldCacheProvider.java
./lucene/facet/src/java/org/apache/lucene/facet/search/StandardFacetsAccumulator.java
./lucene/facet/src/java/org/apache/lucene/facet/sampling/RepeatableSampler.java
./lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
./lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
./solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
./solr/core/src/java/org/apache/solr/SolrLogFormatter.java
./solr/core/src/java/org/apache/solr/logging/jul/JulInfo.java
./solr/core/src/java/org/apache/solr/logging/jul/RecordHandler.java
./solr/core/src/java/org/apache/solr/logging/jul/JulWatcher.java
./solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
{noformat}

2) The jars in lib/ext do not have version numbers in the filenames.  This doesn't affect
operation at all, but it does mean that a casual observer will not know what version is being
included, so it'll be harder to track down potential bugs in those libraries.  Even examining
the filenames within the jars reveals no version information.

                
> Ship setup to log with log4j.
> -----------------------------
>
>                 Key: SOLR-3706
>                 URL: https://issues.apache.org/jira/browse/SOLR-3706
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.3, 5.0
>
>         Attachments: SOLR-3706-maven.patch, SOLR-3706-maven.patch, SOLR-3706.patch, SOLR-3706-solr-log4j.patch,
SOLR-3706-solr-log4j.patch
>
>
> Currently we default to java util logging and it's terrible in my opinion.
> *It's simple built in logger is a 2 line logger.
> *You have to jump through hoops to use your own custom formatter with jetty - either
putting your class in the start.jar or other pain in the butt solutions.
> *It can't roll files by date out of the box.
> I'm sure there are more issues, but those are the ones annoying me now. We should switch
to log4j - it's much nicer and it's easy to get a nice single line format and roll by date,
etc.
> If someone wants to use JUL they still can - but at least users could start with something
decent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message