lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3918) Port index sorter to trunk APIs
Date Wed, 06 Mar 2013 15:40:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594787#comment-13594787
] 

Adrien Grand commented on LUCENE-3918:
--------------------------------------

Regarding PayloadSorter and StoredFieldsSorter I'm just afraid that the fact that they exist
might make users think these are viable options...

bq. IndexSorter is a convenient utility for sorting a Directory end-to-end. Why remove it?

I think taking an AtomicReader as an argument (instead of a Directory) and feeding an IndexWriter
(instead of another Directory) would be much more flexible but then it would just be a call
to IndexWriter.addIndexes... If we want an utility to sort indexes, maybe it should rather
be something callable from command-line? (java oal.index.sorter.IndexSorter fromDir toDir
sortField)

bq. Get rid of SortDoc. Sorter is now abstract class with a helper int[] compute(int[] docs,
T[] values)

I think it's better! Maybe a List instead of an array would be even better so that NumericDocValuesSorter
could use a view over the doc values instead of loading all of them into memory?

Reusage of DocsEnum looks great!





                
> Port index sorter to trunk APIs
> -------------------------------
>
>                 Key: LUCENE-3918
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3918
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/other
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch, LUCENE-3918.patch,
LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message