lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r1460165 - /lucene/dev/trunk/lucene/misc/src/java/org/apache/lucene/index/sorter/SortingAtomicReader.java
Date Sat, 23 Mar 2013 15:22:07 GMT
On Sat, Mar 23, 2013 at 11:12 AM, Adrien Grand <jpountz@gmail.com> wrote:
> On Sat, Mar 23, 2013 at 4:00 PM, Robert Muir <rcmuir@gmail.com> wrote:
>> is it really good that FilteredTerms/FilteredTermsEnum delegate these
>> optional methods by default?
>
> I just wanted to commit an obvious fix but indeed, I think these
> methods should not be overridden in the Filter* impls. I'll open an
> issue.
>

Yes: I agree with your commit (i didnt mean it to come across that way).

It just stuck out to me as a trap in the API.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message