lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Krupansky" <j...@basetechnology.com>
Subject "Bug" no warning message for deprecated class JavaUpdateRequestHandler
Date Mon, 11 Mar 2013 01:51:27 GMT
All of the other format-specific Solr update handlers have a warning that those classes are
deprecated, but the warning is commented out for the JsonUpdateRequestHandler:

@Deprecated
public class JsonUpdateRequestHandler extends UpdateRequestHandler {

  @Override
  public void init(NamedList args) {
    super.init(args);
    setAssumeContentType("application/json");
    // log.warn("Using deprecated class: "+this.getClass().getSimpleName()+" -- replace with
UpdateRequestHandler");
  }

As opposed to, for example, the XmlUpdateRequestHandler:

@Deprecated
public class XmlUpdateRequestHandler extends UpdateRequestHandler {

  @Override
  public void init(NamedList args) {
    super.init(args);
    setAssumeContentType("application/xml");
    log.warn("Using deprecated class: "+this.getClass().getSimpleName()+" -- replace with
UpdateRequestHandler");
  }

Is there a good reason for this discrepancy in JavaUpdateRequestHandler, or is this a “bug”?

Also, I would note that the deprecated handlers are still in trunk even though the deprecations
are in branch_4x.

-- Jack Krupansky
Mime
View raw message