Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 13 Feb 2013 19:48:14 +0000 (UTC)
From: "David Smiley (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12631742.1360599344376.285959.1360784894103@arcas>
In-Reply-To: <JIRA.12631742.1360599344376@arcas>
References: <JIRA.12631742.1360599344376@arcas>
Subject: [jira] [Updated] (LUCENE-4770) GeoShape intersects filter omitted
 matching docs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-4770:
---------------------------------

    Attachment: LUCENE-4770_Spatial_make_prefixTree_simplification_configurable.patch

The attached patch:
* Adds a "simplify" boolean argument to SpatialPrefixTree.getNodes(). If enabled, getNodes() will perform the aforementioned optimization.  FYI it results in ~20-25% reduction in cells.
* Enhanced the simplification algorithm to bubble up to higher levels, pruning away more cells. It becomes exponentially less likely to happen as you move up but it can and will happen.
* The TermQuery strategy won't simplify at index time (this is a change) and will simplify at search time.  Note indexed non-point shapes will use ~20% more disk.
* The RecursivePrefixTree strategy will continue to simplify indexed shapes. It has a search-time algorithm that doesn't use PrefixTree.getNodes().
* Simplified the API subclassing contract for SpatialPrefixTree, and thus removed an overriding method in both Geohash & Quad implementations.

p.s. Thanks so much for developing tests, Florian!

If there are no problems discussed with this patch then I plan to commit it in ~32 hours.
                
> GeoShape intersects filter omitted matching docs
> ------------------------------------------------
>
>                 Key: LUCENE-4770
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4770
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>    Affects Versions: 4.0, 4.1
>            Reporter: Florian Schilling
>            Assignee: David Smiley
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4770.patch, LUCENE-4770_Spatial_make_prefixTree_simplification_configurable.patch
>
>
> SpatialPrefixTree#recursiveGetNodes uses an optimization that prevents
> recursion into the deepest tree level if a parent node in the penultimate
> level covers all its children.  This produces a bug if the optimization
> happens both at indexing and at query/filter time.
> [Original post|https://github.com/elasticsearch/elasticsearch/issues/2626]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org