Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2390CE34A for ; Tue, 12 Feb 2013 15:27:14 +0000 (UTC) Received: (qmail 31503 invoked by uid 500); 12 Feb 2013 15:27:12 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 31445 invoked by uid 500); 12 Feb 2013 15:27:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 31438 invoked by uid 99); 12 Feb 2013 15:27:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2013 15:27:12 +0000 Date: Tue, 12 Feb 2013 15:27:12 +0000 (UTC) From: "Shai Erera (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-4769) Add a CountingFacetsAggregator which reads ordinals from a cache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576681#comment-13576681 ] Shai Erera commented on LUCENE-4769: ------------------------------------ I wonder, since CachedInts for a segment is created only once, if we should make it more generic, and work w/ IntDecoder instead of hard-coding to dgap+vint? Then, we can make this class top-level, e.g. as OrdinalsCache with a static getCachedInts/Ords for a segment? Otherwise, I'll add an assert to CachedIntsCountingFacetsAggregator to ensure the decoder used is DGapVInt. > Add a CountingFacetsAggregator which reads ordinals from a cache > ---------------------------------------------------------------- > > Key: LUCENE-4769 > URL: https://issues.apache.org/jira/browse/LUCENE-4769 > Project: Lucene - Core > Issue Type: New Feature > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-4769.patch, LUCENE-4769.patch > > > Mike wrote a prototype of a FacetsCollector which reads ordinals from a CachedInts structure on LUCENE-4609. I ported it to the new facets API, as a FacetsAggregator. I think we should offer users the means to use such a cache, even if it consumes more RAM. Mike tests show that this cache consumed x2 more RAM than if the DocValues were loaded into memory in their raw form. Also, a PackedInts version of such cache took almost the same amount of RAM as straight int[], but the gains were minor. > I will post the patch shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org