Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 1 Feb 2013 12:40:16 +0000 (UTC)
From: "Simon Willnauer (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12629589.1359409206209.229164.1359722416432@arcas>
In-Reply-To: <JIRA.12629589.1359409206209@arcas>
References: <JIRA.12629589.1359409206209@arcas>
Subject: [jira] [Commented] (LUCENE-4728) Allow CommonTermsQuery to be
 highlighted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568702#comment-13568702 ] 

Simon Willnauer commented on LUCENE-4728:
-----------------------------------------

bq. wait i dont get it... its another instanceof block.
no not necessarily. Since for rewrite I need to get the field of the query otherwise I can't get a IndexReader in WeightedSpanTermExtractor. The other problem here is that WeightedSpanTermExtractor doesn't rewrite against a global reader but rather against a "reanalyzed" reader which might bring up problems in the case of CommonTermsQuery which will in-turn create a different BooleanQuery. 

bq. I dont think highlighters should depend on the concrete queries, only the abstract apis (just like i think modules shouldnt depend on analyzers modules)... otherwise its a sign something is wrong.

dude this is wishful thinking unless we fix our API to allow to do positional queries. Really we already rely on it with ConstantScore / FilteredQuery calling getQuery() we also rely on BQ etc. and TermQuery which is not abstract api.
                
> Allow CommonTermsQuery to be highlighted
> ----------------------------------------
>
>                 Key: LUCENE-4728
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4728
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 4.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4728.patch, LUCENE-4728.patch
>
>
> Add support for CommonTermsQuery to all highlighter impls. 
> This might add a dependency (query-jar) to the highlighter so we might think about adding it to core?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org