lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4796) NamedSPILoader.reload needs to be synchronized
Date Mon, 25 Feb 2013 23:52:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586481#comment-13586481
] 

Hoss Man commented on LUCENE-4796:
----------------------------------

+1 ... looks good to me.
                
> NamedSPILoader.reload needs to be synchronized
> ----------------------------------------------
>
>                 Key: LUCENE-4796
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4796
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Uwe Schindler
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4796.patch, LUCENE-4796.patch
>
>
> Spun off of SOLR-4373: as discsused with uwe on IRC, NamedSPILoader.reload is not thread
safe: it reads from this.services at the beginging of hte method, makes additions based on
the method input, and then overwrites this.services at the end of the method.  if the method
is called by two threads concurrently, the entries added by threadB could be lost if threadA
enters the method before threadB and exists the method after threadB

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message