lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4769) Add a CountingFacetsAggregator which reads ordinals from a cache
Date Tue, 12 Feb 2013 04:59:18 GMT


Robert Muir commented on LUCENE-4769:

I still dont get why you need anything special here, more than what Lucene already provides.

You seem hell-bent on the idea that lucene should have a getInts(docid, IntsRef) api for facets.

What I'm trying to say is, if you really think thats the API you should have, nothing in lucene
stops you from doing this, just add it:

package org.apache.lucene.facet.index;

abstract class FacetDocValues extends BinaryDocValues {
  abstract void getInts(int docid, IntsRef ref);

What is the problem? You can then make a jazillion implementations like LUCENE-4764 extend
that API and have one collector that uses it.

> Add a CountingFacetsAggregator which reads ordinals from a cache
> ----------------------------------------------------------------
>                 Key: LUCENE-4769
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4769.patch
> Mike wrote a prototype of a FacetsCollector which reads ordinals from a CachedInts structure
on LUCENE-4609. I ported it to the new facets API, as a FacetsAggregator. I think we should
offer users the means to use such a cache, even if it consumes more RAM. Mike tests show that
this cache consumed x2 more RAM than if the DocValues were loaded into memory in their raw
form. Also, a PackedInts version of such cache took almost the same amount of RAM as straight
int[], but the gains were minor.
> I will post the patch shortly.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message