lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4750) Convert DrillDown to DrillDownQuery
Date Sat, 09 Feb 2013 20:51:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575260#comment-13575260
] 

Shai Erera commented on LUCENE-4750:
------------------------------------

bq. I don't really like how toString shows impl details (eg, the $facet field name), vs eg
just the CP/s of each drill-down, but I think that's pretty minor ...

That's the current state of the patch anyway. Creating a BQ on-the-fly won't change it. And
I'm not sure if it's bad .. that way, toString shows you the query that is executed, so e.g.
if you indexed into multiple category lists, you see that right-away. Although, I agree it
may be redundant information for those who index into one category list...

bq. Maybe we could do this if the original query isn't using coord? But maybe leave this as
future TODO optimization

Ok.
                
> Convert DrillDown to DrillDownQuery
> -----------------------------------
>
>                 Key: LUCENE-4750
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4750
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>         Attachments: LUCENE-4750.patch
>
>
> DrillDown is a utility class for creating drill-down queries over a base query and a
bunch of categories. We've been asked to support AND, OR and AND of ORs. The latter is not
so simple as a static utility method though, so instead we have some sample code ...
> Rather, I think that we can just create a DrillDownQuery (extends Query) which takes
a baseQuery in its ctor and exposes add(CategoryPath...), such that every such group of categories
is AND'ed with other groups, and internally they are OR'ed. It's very similar to how you would
construct a BooleanQuery, only simpler and specific to facets.
> Internally, it would build a BooleanQuery and delegate rewrite, createWeight etc to it.
> That will remove the need for the static utility methods .. or we can keep static term()
for convenience.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message