lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4746) Create a move method in Directory.
Date Sat, 02 Feb 2013 16:02:19 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569574#comment-13569574
] 

Michael McCandless commented on LUCENE-4746:
--------------------------------------------

OK, I agree IndexWriter.moveIndices would be a nice addition to
Lucene, and that we'll need to bring back Directory.rename/move to do
it efficiently.

bq. 3.0 formatted indexes with shared doc stores. We shouldnt support this.

+1

bq. I dont want a slow (but safe) addIndexes and a fast (but unsafe) moveIndexes. So if we
do this, i want java7 as a minimum requirement so we can at least try to create a hard link
in Directory.copy() to make addIndexes fast too.

No matter what moveIndexes will be unsafe right?  Meaning if you hit an exc part way through
then some or all of your source indices are corrupt ... the dest index should be fine though
(and, should only reflect all or none of the additions I think).

+1 for hard link via Dir.copy; that would be nice!  Should we just require Java 7 on trunk
now...?
                
> Create a move method in Directory.
> ----------------------------------
>
>                 Key: LUCENE-4746
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4746
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4746.patch
>
>
> I'd like to make a move method for directory.
> We already have a move for Solr in DirectoryFactory, but it seems it belongs at the directory
level really.
> The default impl can do a copy and delete, but most implementations will be able to optimize
to a rename.
> Besides the move we do for Solr (to move a replicated index into place), it would also
be useful for another feature I'd like to add - the ability to merge an index with moves rather
than copies. In some cases, you don't need/want to copy all the files and could just rename/move
them. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message