lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4728) Allow CommonTermsQuery to be highlighted
Date Fri, 01 Feb 2013 12:40:16 GMT


Simon Willnauer commented on LUCENE-4728:

bq. wait i dont get it... its another instanceof block.
no not necessarily. Since for rewrite I need to get the field of the query otherwise I can't
get a IndexReader in WeightedSpanTermExtractor. The other problem here is that WeightedSpanTermExtractor
doesn't rewrite against a global reader but rather against a "reanalyzed" reader which might
bring up problems in the case of CommonTermsQuery which will in-turn create a different BooleanQuery.

bq. I dont think highlighters should depend on the concrete queries, only the abstract apis
(just like i think modules shouldnt depend on analyzers modules)... otherwise its a sign something
is wrong.

dude this is wishful thinking unless we fix our API to allow to do positional queries. Really
we already rely on it with ConstantScore / FilteredQuery calling getQuery() we also rely on
BQ etc. and TermQuery which is not abstract api.
> Allow CommonTermsQuery to be highlighted
> ----------------------------------------
>                 Key: LUCENE-4728
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 4.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.2, 5.0
>         Attachments: LUCENE-4728.patch, LUCENE-4728.patch
> Add support for CommonTermsQuery to all highlighter impls. 
> This might add a dependency (query-jar) to the highlighter so we might think about adding
it to core?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message