lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4728) Allow CommonTermsQuery to be highlighted
Date Fri, 01 Feb 2013 12:30:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568696#comment-13568696
] 

Robert Muir commented on LUCENE-4728:
-------------------------------------

wait i dont get it... its another instanceof block.

I think we would just do the same trick in WeightedSpanTermExtractor, and then in the test
have a mock query that rewrites to primitives (e.g. boolean query) and not have highlighter
depend on the queries module?

I dont think highlighters should depend on the concrete queries, only the abstract apis (just
like i think modules shouldnt depend on analyzers modules)... otherwise its a sign something
is wrong.
                
> Allow CommonTermsQuery to be highlighted
> ----------------------------------------
>
>                 Key: LUCENE-4728
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4728
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 4.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4728.patch, LUCENE-4728.patch
>
>
> Add support for CommonTermsQuery to all highlighter impls. 
> This might add a dependency (query-jar) to the highlighter so we might think about adding
it to core?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message