lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4310) If groups.ngroups is specified, the docList's numFound should be the number of groups
Date Thu, 28 Feb 2013 20:05:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589876#comment-13589876
] 

Hoss Man commented on SOLR-4310:
--------------------------------

If i had to guess, i suspect what you want to change is org.apache.solr.search.grouping.endresulttransformer.MainEndResultTransformer
.. but there is also org.apache.solr.search.grouping.endresulttransformer.SimpleEndResultTransformer,
and i don't know enough about how grouping works to understand the distinction (should one
of these be subclassing the other?)

Once you track down which of these need changed -- or if both need changed -- it would be
best to have either a test of each distributed code path changed, or a "defensive" test showing
that code path which shouldn't be affected by this change is in fact not affected.
                
> If groups.ngroups is specified, the docList's numFound should be the number of groups
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-4310
>                 URL: https://issues.apache.org/jira/browse/SOLR-4310
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 4.1
>            Reporter: Amit Nithian
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 4.2
>
>         Attachments: SOLR-4310_2.patch, SOLR-4310.patch
>
>
> If you group by a field, the response may look like this:
> <lst name="grouped">
> <lst name="series">
> <int name="matches">138</int>
> <int name="ngroups">1</int>
> <result name="doclist" numFound="138" start="0">
> <doc>
> <int name="id">267038365</int>
> <str name="name">
> Larry's Grand Ole Garage Country Dance - Pure Country
> </str>
> </doc>
> </result>
> </lst>
> </lst>
> and if you specify group.main then the doclist becomes the result and you lose all context
of the number of groups. If you want to keep your response format backwards compatible with
clients (i.e. clients who don't know about the grouped format), setting group.main=true solves
this BUT the numFound is the number of raw matches instead of the number of groups. This may
have downstream consequences.
> I'd like to propose that if the user specifies ngroups=true then when creating the returning
DocSlice, set the numFound to be the number of groups instead of the number of raw matches
to keep the response consistent with what the user would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message