lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3918) Port index sorter to trunk APIs
Date Wed, 20 Feb 2013 13:41:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582176#comment-13582176
] 

Adrien Grand commented on LUCENE-3918:
--------------------------------------

This patch seems to have been created against an old 4.x branch (4.0 or 4.1 maybe?). We usually
commit new features to trunk before backporting them to branch_4x, could you update the patch
so that it can apply on top of trunk? Some comments on this new patch:
 - All Sorter implementations open the provided Directory and close it before returning, shouldn't
this interface directly take an IndexReader as an argument?
 - SorterUtil.sort uses the stored fields API to create a new sorted index, this won't work
in a few cases, especially if fields are not stored. I think it should rather use {{IndexWriter.addIndexes(IndexReader...)}}.
 - SortingIndexReader constructor expects a CompositeIndexReader and calls {{new SlowCompositeReaderWrapper()}}
to have an atomic view of this reader. I think it should take any index reader and wrap it
using {{SlowCompositeReaderWrapper.wrap}} (compared to {{new SlowCompositeReaderWrapper()}},
this optimizes the case where the composite reader only wraps a single atomic reader).
 - Why does SortingIndexReader.getLiveDocs always return null?
                
> Port index sorter to trunk APIs
> -------------------------------
>
>                 Key: LUCENE-3918
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3918
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/other
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-3918.patch, LUCENE-3918.patch
>
>
> LUCENE-2482 added an IndexSorter to 3.x, but we need to port this
> functionality to 4.0 apis.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message