lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <>
Subject [jira] [Commented] (SOLR-2996) make "q=*" not suck in the lucene and edismax parsers
Date Thu, 28 Feb 2013 09:33:14 GMT


Alan Woodward commented on SOLR-2996:

I've had a quick look, and I think it's just a matter of changing the Clause() definition
in QueryParser.jj.  (Warning: untested patch)

Index: solr/core/src/java/org/apache/solr/parser/QueryParser.jj
--- solr/core/src/java/org/apache/solr/parser/QueryParser.jj	(revision 1451143)
+++ solr/core/src/java/org/apache/solr/parser/QueryParser.jj	(working copy)
@@ -195,7 +195,8 @@
-   q=Term(field)
+   <STAR> {q=handleBareTokenQuery("*", "*", fuzzySlop, prefix, true, fuzzy, regexp)}
+   | q=Term(field)
    | <LPAREN> q=Query(field) <RPAREN> (<CARAT> boost=<NUMBER>)?
    | (localParams = <LPARAMS> (<CARAT> boost=<NUMBER>)? { q=getLocalParams(field,
localParams.image); }  )


I don't have time to look at this properly now, but I'll probably get a chance next week.
 Feel free to try out that patch though!

> make "q=*" not suck in the lucene and edismax parsers
> -----------------------------------------------------
>                 Key: SOLR-2996
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers
>            Reporter: Hoss Man
> More then a few users have gotten burned by thinking that "{{\*}}" is the appropriate
syntax for "match all docs" when what it really does (unless i'm mistaken) is create a prefix
query on the default search field using a blank string as the prefix.
> since it seems very unlikely that anyone has a genuine usecase for making a prefix query
with a blank prefix, we should change the default behavior of the LuceneQParser and EDismaxQParsers
(and any other Qparsers that respect {{\*:\*}} if i'm forgetting them) to treat this situation
the same as {{\*:\*}}.  we can offer a (local)param to force the old behavior if someone really
wants it.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message