lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4674) Consistently set offset=0 in BytesRef.copyBytes
Date Thu, 10 Jan 2013 11:08:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549538#comment-13549538
] 

Adrien Grand commented on LUCENE-4674:
--------------------------------------

I still find confusing that we are allowed to write past offset + length but not before offset.

Switching to the java.nio buffers sounds good.
                
> Consistently set offset=0 in BytesRef.copyBytes
> -----------------------------------------------
>
>                 Key: LUCENE-4674
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4674
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4674.patch
>
>
> BytesRef.copyBytes(BytesRef other) has two branches:
>  - either the destination array is large enough and it will copy bytes after offset,
>  - or it needs to resize and in that case it will set offset = 0.
> I think this method should always set offset = 0 for consistency, and to avoid resizing
when other.length is larger than this.bytes.length - this.offset but smaller than this.bytes.length.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message