lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4265) Fix decoding of GET/POST parameters for servlet containers with non-UTF-8 URL parsing (Tomcat)
Date Sat, 05 Jan 2013 19:44:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544799#comment-13544799
] 

Uwe Schindler commented on SOLR-4265:
-------------------------------------

bq. In my experience, Jetty defaulted to UTF-8 for the URL encoding. AFAIK, we've never needed
to tweak jetty charset config.

Yes, thats right. Dawid and I were discussing about the behaviour regarding the encoding from
POST content (if it overrides the URL encoding or not), although the used defaults were different
in both web container. The difference with Jetty was simply that the encoding for URL parameters
is UTF-8, see the above code from Request.java where it parses the query string.

The final patch does exactly the same like jetty always did, only the default is fixed to
be UTF-8 on any web container.
                
> Fix decoding of GET/POST parameters for servlet containers with non-UTF-8 URL parsing
(Tomcat)
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4265
>                 URL: https://issues.apache.org/jira/browse/SOLR-4265
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 4.0
>         Environment: Windows but, environment independent
>            Reporter: Alex Rocher
>            Assignee: Uwe Schindler
>         Attachments: CropperCapture[4].png, CropperCapture[5].png, CropperCapture[6].png,
SOLR-4265.patch, SOLR-4265.patch, SOLR-4265.patch, SOLR-4265.patch, SOLR-4265.patch, SolrDispatchFilter.java.patch
>
>
> When you type an accent (in french language for example) in the console query tester,
there's no charset conversion (servlet request charset conversion)
> Eg.: "même" is converted into it's ISO-8859-1 representation ==> fail
> The reason : getCharacterEncoding from HTTPRequest is not tested. Il it's null, il will
assume to convert an UTF-8 encoding charset.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message