lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sivan Yogev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4621) FacetIndexing/SearchParams house cleaning
Date Thu, 13 Dec 2012 11:56:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530929#comment-13530929
] 

Sivan Yogev commented on LUCENE-4621:
-------------------------------------

OK, ready to commit from my side.
                
> FacetIndexing/SearchParams house cleaning
> -----------------------------------------
>
>                 Key: LUCENE-4621
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4621
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>         Attachments: LUCENE-4621.patch, LUCENE-4621.patch
>
>
> FacetIndexingParams lets you configure few things such as OrdinalPolicy, PathPolicy and
partitionSize. However, in order to set them you must extend DefaultFacetIndexingParams and
override fixedXY(), as the respective getters are final.
> I'd like to do the following:
> * Turn FacetIndexingParams and FacetSearchParams into concrete classes, rather than interfaces.
The reason they are interfaces because one app once wants to have one class which implements
both. Since FSP holds FIP, I don't think that's needed.
> * Add setters to FacetIndexingParams for the relevant configuration parameters, rather
than forcing someone to extend the class. Extensions should really be for special cases, which
we haven't identified so far (except overriding these settings), hence why there's only DefaultFIP/FSP.
> * Add some javadocs...
> * I'm sure, w/ my pedantic and perfectionist nature, that more thing will be done once
I get to it :).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message