lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4615) Remove Int/FloatArrayAllocator from facet module?
Date Tue, 11 Dec 2012 14:03:21 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528981#comment-13528981
] 

Commit Tag Bot commented on LUCENE-4615:
----------------------------------------

[branch_4x commit] Shai Erera
http://svn.apache.org/viewvc?view=revision&revision=1420163

LUCENE-4615: do not reuse facet aggregation arrays by default; added ReusingFacetArrays

                
> Remove Int/FloatArrayAllocator from facet module?
> -------------------------------------------------
>
>                 Key: LUCENE-4615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4615
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Michael McCandless
>            Assignee: Shai Erera
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4615.patch
>
>
> Spinoff from LUCENE-4600.
> It makes me nervous to have allocation tied to our public APIs ... and the ability for
Int/FloatArrayAllocator to hold onto N arrays indefinitely makes me even more nervous.  I
think we should just trust java/GC to do their job here and free the storage as soon as faceting
is done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message