lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4593) clean up FST storage abstractions
Date Thu, 06 Dec 2012 16:06:11 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511486#comment-13511486
] 

Michael McCandless commented on LUCENE-4593:
--------------------------------------------

bq. I really wish the buffering and stuff was instead encapsulated in Builder or somewhere
else so that FST was simpler and immutable.

+1

We now use the same class for writing as for reading, which is very confusing.
                
> clean up FST storage abstractions
> ---------------------------------
>
>                 Key: LUCENE-4593
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4593
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-4593.patch
>
>
> I was looking at James patch for LUCENE-3298, and I thought that you know, FST *almost*
abstracts its underlying "i/o" (storage) via reader/writer abstractions.
> It would be good to try to work on this more, e.g. we can imagine a little abstraction
like lucene has a Store (Directory). 
> This way maybe we could cleanup the packed vs non-packed, allow for > 2GB fsts without
slowing down small ones, and so on.
> I have a patch that is like an amoeba-step towards this

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message