lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4143) setRequestHandler - option to not set qt parameter
Date Thu, 06 Dec 2012 17:09:09 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511518#comment-13511518
] 

Shawn Heisey commented on SOLR-4143:
------------------------------------

I will look into whether I can create a second parameter, something like "qt.pathonly" that
defaults to false (bikeshedding on the parameter name welcome).  That would keep current behavior
intact but allow for the new behavior that my use case requires.  I can then create a second
setRequestHandler method with the boolean, and have the current method just call the new method.
                
> setRequestHandler - option to not set qt parameter
> --------------------------------------------------
>
>                 Key: SOLR-4143
>                 URL: https://issues.apache.org/jira/browse/SOLR-4143
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 4.0
>         Environment: solr-impl    4.1-SNAPSHOT 1416639M - ncindex - 2012-12-03 12:54:38
>            Reporter: Shawn Heisey
>             Fix For: 5.0
>
>
> The setRequestHandler method does what I expect in one way - it changes the URL path
from /select to the String argument.  It is however doing something that I did not expect,
which is setting the qt parameter on the query as well.  Here is the code:
> private static final String PING_HANDLER = "/admin/ping";
> query.setRequestHandler(PING_HANDLER);
> This is resulting in the following exception being logged in my Solr 3.5.0 servers. 
I am not including the whole exception, because this issue is for SolrJ 4, not Solr 3.5, and
the 3.5 version is working as it was designed.
> {code}
> Dec 3, 2012 4:04:01 PM org.apache.solr.common.SolrException log
> SEVERE: org.apache.solr.common.SolrException: Cannot execute the PingRequestHandler recursively
>         at org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:60)
>         at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:208)
> {code}
> I believe it would be useful to include an alternate setRequestHandler method that includes
a boolean option deciding whether or not to also set the qt parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message