lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4085) Commit-free ExternalFileField
Date Sun, 02 Dec 2012 00:23:59 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508114#comment-13508114
] 

Adrien Grand commented on SOLR-4085:
------------------------------------

Mikhail,

I took a quick look at your patch and I liked the fact that you didn't need to modify files
outside of ExternalFileField and FileFLoatSouce to support commit-free updates. On the other
hand, because of the lack of atomicity and the problem with concurrent reloads, I think it
should not be applied to Solr because it could lead to confusing behaviors. (This doesn't
mean that your work isn't valuable. As stated on http://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work,
even patchs that are not committed are useful to the community.)
                
> Commit-free ExternalFileField
> -----------------------------
>
>                 Key: SOLR-4085
>                 URL: https://issues.apache.org/jira/browse/SOLR-4085
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.1
>            Reporter: Mikhail Khludnev
>              Labels: externalfilefield
>         Attachments: SOLR-4085.patch
>
>
> Let's reload ExternalFileFields without commit!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message