lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in Lucene against the original impl
Date Sat, 01 Dec 2012 23:59:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508110#comment-13508110
] 

Adrien Grand commented on LUCENE-4584:
--------------------------------------

Testing cross-implementation compression/decompression would indeed be very cool but I'm a
little worried about adding the sources of LZ4 and a task to compile C code to the lucene-core
build (or maybe I could do these LZ4 tests in a dedicated module so that it doesn't make lucene-core
depend on native code?).

I think we should also compare the output bytes to make sure the compressor is efficient (a
perfectly valid LZ4 implementation would be to always write a single sequence that only contains
the input bytes as literals, this is what should happen only when the input is incompressible).
Given that the LZ4 output depends on the endianess of the machine, this can unfortunately
only be done with static files.
                
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
>                 Key: LUCENE-4584
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4584
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Blocker
>             Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact
same way as the original impl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message