Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates
 209.85.216.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <003d01cdb873$473507e0$d59f17a0$@thetaphi.de>
References: 
 <CAAHmpkiHJpQ=WUDQq0DjQGVCvr89+7+f2-X0zL_bCWrqPCoWVA@mail.gmail.com>
 <003d01cdb873$473507e0$d59f17a0$@thetaphi.de>
From: Robert Muir <rcmuir@gmail.com>
Date: Thu, 1 Nov 2012 17:04:18 -0400
Message-ID: 
 <CAOdYfZUVKGamQ72FFFm_8Awbyd+T4jbk43qELpfUA_OLqePMiw@mail.gmail.com>
Subject: Re: [DISCUSS] Merge DocsEnum and DocsAndPositionsEnum into
 PostingsEnum
To: dev@lucene.apache.org
Cc: simon.willnauer@gmail.com
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 1, 2012 at 4:55 PM, Uwe Schindler <uwe@thetaphi.de> wrote:
> +1, I think PostingsEnum ist he much better idea! I was thinking about th=
at several times. In fact DocsEnum is just a specialized DocIdSetIterator, =
so I never understood the difference in the early Lucene 4 days. Now we hav=
e some extra methods, but most of them are optional and a PostingsEnum exte=
nds DocIdSetIterator (I would like to have *implements* more...) is perfect=
ly fine for all those use cases. And as both Scorer and PostingsEnum extend=
 the same base class, this makes code reuseable and looking identical in lo=
ts of cases (like simple Filters). A filter for a Term could directly retur=
n the PostingsEnum for this term in getDocIdSet()...
>

I was frustrated with some of the same things as simon, and thought
about the 'implements' too. (i actually went so far as to make a quick
prototype patch to see what it look like:
http://pastebin.com/vum1mx9H). I don't like that if you write a codec,
you must write duplicate enums and cannot have e.g. your positional
enum extend your docs one and so forth.

I also think it limits us for the Scorer case (it extends DocsEnum
now, but what if you wanted a Scorer where you could walk its
positions...)

But anyway I think I like Simon's idea (we can deal with the interface
idea separately).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org