Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BCC2D896 for ; Thu, 15 Nov 2012 10:39:39 +0000 (UTC) Received: (qmail 83815 invoked by uid 500); 15 Nov 2012 10:39:38 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 83595 invoked by uid 500); 15 Nov 2012 10:39:37 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 83576 invoked by uid 99); 15 Nov 2012 10:39:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 10:39:37 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of serera@gmail.com designates 209.85.160.48 as permitted sender) Received: from [209.85.160.48] (HELO mail-pb0-f48.google.com) (209.85.160.48) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 10:39:29 +0000 Received: by mail-pb0-f48.google.com with SMTP id rq13so1098060pbb.35 for ; Thu, 15 Nov 2012 02:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Le75LZFh0SVlI2+PpaznPkeA/39Cwa99BOWg98K/xsE=; b=HuJM+xr+xajr6KaLtzbdXcIwVzHuIr9MUkBxBnwnFuz+3zCbWUHUv88+pZ+u2VfSfg 07fX3w/LcuBRiYAD8oV4qSFim0HyqyTSVRSR1lyTVZvSYntSwI3RjgsNkvvKsxFf1DAc SAyT8CqKwmdNKr5niaiX015PIStWlblW9N/rntXF3fl6jYeCa/AgXBJQqV3DzTDVoOov e1UresavZnnUXTG1yrA2DNovhBvRJF+KjtF6Zw2Leyjav+UjGD9KSLCqLf/wtHJ72Dyc tJAa3doYGyXydPsxHKHAXUbKZo6wHscexJJTGh783g7teWjdQm3HtXwg+CaaXGa/FRy9 hrUQ== MIME-Version: 1.0 Received: by 10.68.189.163 with SMTP id gj3mr3331909pbc.110.1352975948315; Thu, 15 Nov 2012 02:39:08 -0800 (PST) Received: by 10.66.126.5 with HTTP; Thu, 15 Nov 2012 02:39:08 -0800 (PST) Date: Thu, 15 Nov 2012 12:39:08 +0200 Message-ID: Subject: Question about CompressingCodec From: Shai Erera To: dev@lucene.apache.org Content-Type: multipart/alternative; boundary=e89a8ff1ccd2c9fd8404ce864238 X-Virus-Checked: Checked by ClamAV on apache.org --e89a8ff1ccd2c9fd8404ce864238 Content-Type: text/plain; charset=ISO-8859-1 Hi I looked at CompressingCodec and had a couple of questions until I realized it's a test code only. I understand that creating a Codec class is not favorable, because of back-compat issues (that may arise in the future), so I'll ask that -- what if we made it a non-test class, which takes any Codec to wrap (i.e. not default to Lucene41Codec)? I don't have any strong feelings for or against it, so I'm ok if the general feeling is that we should provide CompressingStoredFieldsFormat only. While at that, should CompressingStoredFieldsFormat be named CompressingStoredFieldsFormat41 or something like that, preparing it for future changes? Or ... or we can add the version to the name only when it's actually changed ... Shai --e89a8ff1ccd2c9fd8404ce864238 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi

I looked at CompressingCodec and had a coup= le of questions until I realized it's a test code only. I understand th= at creating a Codec class is not favorable, because of back-compat issues (= that may arise in the future), so I'll ask that -- what if we made it a= non-test class, which takes any Codec to wrap (i.e. not default to Lucene4= 1Codec)? I don't have any strong feelings for or against it, so I'm= ok if the general feeling is that we should provide CompressingStoredField= sFormat only.

While at that, should CompressingStoredFieldsFormat be named Compressin= gStoredFieldsFormat41 or something like that, preparing it for future chang= es? Or ... or we can add the version to the name only when it's actuall= y changed ...

Shai
--e89a8ff1ccd2c9fd8404ce864238--