Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <CAOdYfZUVKGamQ72FFFm_8Awbyd+T4jbk43qELpfUA_OLqePMiw@mail.gmail.com>
References: 
 <CAAHmpkiHJpQ=WUDQq0DjQGVCvr89+7+f2-X0zL_bCWrqPCoWVA@mail.gmail.com>
 <003d01cdb873$473507e0$d59f17a0$@thetaphi.de>
 <CAOdYfZUVKGamQ72FFFm_8Awbyd+T4jbk43qELpfUA_OLqePMiw@mail.gmail.com>
From: Michael McCandless <lucene@mikemccandless.com>
Date: Thu, 1 Nov 2012 18:00:54 -0400
Message-ID: 
 <CAL8PwkbYDOgjMi=EsxJvf4W6NRUp0yGm3BV-dO2cvw=EoQm0ZA@mail.gmail.com>
Subject: Re: [DISCUSS] Merge DocsEnum and DocsAndPositionsEnum into
 PostingsEnum
To: dev@lucene.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

+1, this makes total sense!

Mike McCandless

http://blog.mikemccandless.com

On Thu, Nov 1, 2012 at 5:04 PM, Robert Muir <rcmuir@gmail.com> wrote:
> On Thu, Nov 1, 2012 at 4:55 PM, Uwe Schindler <uwe@thetaphi.de> wrote:
>> +1, I think PostingsEnum ist he much better idea! I was thinking about t=
hat several times. In fact DocsEnum is just a specialized DocIdSetIterator,=
 so I never understood the difference in the early Lucene 4 days. Now we ha=
ve some extra methods, but most of them are optional and a PostingsEnum ext=
ends DocIdSetIterator (I would like to have *implements* more...) is perfec=
tly fine for all those use cases. And as both Scorer and PostingsEnum exten=
d the same base class, this makes code reuseable and looking identical in l=
ots of cases (like simple Filters). A filter for a Term could directly retu=
rn the PostingsEnum for this term in getDocIdSet()...
>>
>
> I was frustrated with some of the same things as simon, and thought
> about the 'implements' too. (i actually went so far as to make a quick
> prototype patch to see what it look like:
> http://pastebin.com/vum1mx9H). I don't like that if you write a codec,
> you must write duplicate enums and cannot have e.g. your positional
> enum extend your docs one and so forth.
>
> I also think it limits us for the Scorer case (it extends DocsEnum
> now, but what if you wanted a Scorer where you could walk its
> positions...)
>
> But anyway I think I like Simon's idea (we can deal with the interface
> idea separately).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org