Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A70BEDDB9 for ; Sun, 4 Nov 2012 15:40:22 +0000 (UTC) Received: (qmail 19915 invoked by uid 500); 4 Nov 2012 15:40:13 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 19693 invoked by uid 500); 4 Nov 2012 15:40:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 19653 invoked by uid 99); 4 Nov 2012 15:40:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Nov 2012 15:40:12 +0000 Date: Sun, 4 Nov 2012 15:40:12 +0000 (UTC) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Message-ID: <807102136.65920.1352043612457.JavaMail.jiratomcat@arcas> In-Reply-To: <2046993804.65915.1352041933017.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (LUCENE-4534) WFST/AnalyzingSuggest don't handle keys containing 0 bytes correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-4534: --------------------------------------- Attachment: LUCENE-4534.patch Patch w/ failing test case for WFSTCompletionLookup and AnalyzingSuggester. > WFST/AnalyzingSuggest don't handle keys containing 0 bytes correctly > -------------------------------------------------------------------- > > Key: LUCENE-4534 > URL: https://issues.apache.org/jira/browse/LUCENE-4534 > Project: Lucene - Core > Issue Type: Bug > Reporter: Michael McCandless > Fix For: 4.1, 5.0 > > Attachments: LUCENE-4534.patch > > > While binary terms w/ 0 bytes are rare, they are "allowed" but will cause exceptions with at least WFST/AnalyzingSuggester. > I think to fix this we should pass custom Comparator to the offline sorter that decodes each BytesRef key and does the actual comparison we want, instead of using separator and relying on BytesRef.compareTo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org