Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of hsn@filez.com designates
 64.6.108.239 as permitted sender)
Message-ID: <50B7AE16.80002@filez.com>
Date: Thu, 29 Nov 2012 19:48:54 +0100
From: Radim Kolar <hsn@filez.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: dev@lucene.apache.org
Subject: pro coding style
References: <50B4B68E.80007@designware.dk>
 <93DCE9EF-3569-4A9B-896D-0D991BE90037@gmail.com>
 <50B4D128.6050106@designware.dk>
 <C8B4D34E-82DA-49EE-BC06-3FF9B9D91731@gmail.com> <50B4E9D5.6010206@filez.com>
 <91D07086FA674E32838D571ABDB761CD@JackKrupansky> <50B55FBC.3040900@filez.com>
 <5C95F7D6-1489-4CBB-832A-0208197BDFFA@gmail.com>
 <CAL8Pwkbu2uU7sVaPAQ0==1bRYT3Km7qmqbHt9yJAzyniVSLEhA@mail.gmail.com>
 <45F0CB6F-2AA5-434F-8717-E0221A05051A@gmail.com>
 <5CD483E3-3A1D-4695-89C6-8C6872F4D687@gmail.com>
 <CAOdYfZU=MYtNAiExQW6eP0yossKJZ0zaOvSgRqcbCqo3+E=4CA@mail.gmail.com>
 <CAOGUouxpxh+EXz-GOypaFweQ+7EmSg8UBcvX-j2GMm+Vt3-tEw@mail.gmail.com>
 <50B6B576.8030604@filez.com>
 <CAN4YXveVf_0B7o0RPd6f9o5Ytc=SOfdxik6+_pd2xAeGN6y_JQ@mail.gmail.com>
In-Reply-To: 
 <CAN4YXveVf_0B7o0RPd6f9o5Ytc=SOfdxik6+_pd2xAeGN6y_JQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

if you talk about my yesterday work then no reformats were done because 
code was already properly formatted. Also all code was hand written, no 
generated code was used. Generated code is not committed to git anyway.

my hard limits for code quality (checked at commit):
* no findbugs warnings with level 14+
* code coverage 80%
* code coverage in critical parts 95%
* list of PMD warnings to stop commit
* generation of call tree graph - check it for cycles, checking for 
calling same procedure from different levels (indicates bad code flow)
* all eclipse warnings turned into errors
* patched eclipse compiler to do better flow analysis
* code reformatted at commit
* javadoc everything, no warnings

what you should do:
* stuff i do
    +
* ant -> maven
* svn -> git (way better tools)
* split code into small manageable maven modules
* get more people
* put trust into your testing, not into perfect people
* work faster
* use github to track patches
* use springs for integration testing
* use jenkins to do tests on incoming patches
* do library checks for number of functions really used
* contributor patches should be high priority or you will lose contributors

i am giving sometimes lessons: about 1-2 sessions per year for 14 
people, if i have spare time. But its waste of time, most ppl will not 
follow.

learn this:
SLOW CODING != BUG FREE CODE.
GOOD TESTS + GOOD STATIC TESTING = GOOD BUG FREE CODE
CODE STYLE != GAME WITH SPACES AND { }
GOOD TESTS =  2x TIME NEEDED TO CODE STUFF UNDER TEST
GOOD TESTS ARE MORE VALUABLE THEN GOOD CODE

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org