Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2988D4A2 for ; Thu, 15 Nov 2012 23:15:13 +0000 (UTC) Received: (qmail 79160 invoked by uid 500); 15 Nov 2012 23:15:12 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 78985 invoked by uid 500); 15 Nov 2012 23:15:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 78953 invoked by uid 99); 15 Nov 2012 23:15:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 23:15:12 +0000 Date: Thu, 15 Nov 2012 23:15:12 +0000 (UTC) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Message-ID: <310944144.121563.1353021312398.JavaMail.jiratomcat@arcas> In-Reply-To: <1875686106.121414.1353020352538.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver & Evaluator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498433#comment-13498433 ] Uwe Schindler commented on SOLR-4086: ------------------------------------- Does this fix all default Locale bugs in DIH? If yes, you should remove the DIH class file exclusion from the API violations checker in solr/build.xml. I am happy, that you are taking care, thanks! > Refactor DIH - VariableResolver & Evaluator > ------------------------------------------- > > Key: SOLR-4086 > URL: https://issues.apache.org/jira/browse/SOLR-4086 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler > Affects Versions: 4.0 > Reporter: James Dyer > Assignee: James Dyer > Priority: Minor > Fix For: 4.1, 5.0 > > Attachments: SOLR-4086.patch > > > This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org