Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Thu, 8 Nov 2012 21:32:17 +0000 (UTC)
From: "James Dyer (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <2058449396.88934.1352410337323.JavaMail.jiratomcat@arcas>
In-Reply-To: <2089098612.88626.1352406972157.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (SOLR-4051) DIH Delta updates do not work for all
 locales
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer updated SOLR-4051:
-----------------------------

    Description: 
DIH Writes the last modified date to a Properties file using the default locale.  This gets sent in plaintext to the database at the next delta update.  DIH does not use prepared statements but just puts the date in an SQL Statement in yyyy-mm-dd hh:mm:ss format.  It would probably be best to always format this date in JDBC escape syntax (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472) and java.sql.Timestamp#toString().  To do this, we'd need to parse the user's query and remove the single quotes likely there (and now the quotes would be optional and undesired).  

It might just be simpler to change the SimpleDateFormat to use the root locale as this appears to be the original intent here anyhow.  Affected locales include ja_JP_JP , hi_IN , th_TH
    
> DIH Delta updates do not work for all locales
> ---------------------------------------------
>
>                 Key: SOLR-4051
>                 URL: https://issues.apache.org/jira/browse/SOLR-4051
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Priority: Minor
>
> DIH Writes the last modified date to a Properties file using the default locale.  This gets sent in plaintext to the database at the next delta update.  DIH does not use prepared statements but just puts the date in an SQL Statement in yyyy-mm-dd hh:mm:ss format.  It would probably be best to always format this date in JDBC escape syntax (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472) and java.sql.Timestamp#toString().  To do this, we'd need to parse the user's query and remove the single quotes likely there (and now the quotes would be optional and undesired).  
> It might just be simpler to change the SimpleDateFormat to use the root locale as this appears to be the original intent here anyhow.  Affected locales include ja_JP_JP , hi_IN , th_TH

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org