Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 540D2DB41 for ; Thu, 8 Nov 2012 13:49:15 +0000 (UTC) Received: (qmail 49581 invoked by uid 500); 8 Nov 2012 13:49:14 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 48928 invoked by uid 500); 8 Nov 2012 13:49:13 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 48901 invoked by uid 99); 8 Nov 2012 13:49:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2012 13:49:12 +0000 Date: Thu, 8 Nov 2012 13:49:12 +0000 (UTC) From: "Simon Willnauer (JIRA)" To: dev@lucene.apache.org Message-ID: <1819063569.86704.1352382552965.JavaMail.jiratomcat@arcas> In-Reply-To: <554218056.68404.1352113452102.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (LUCENE-4537) Move RateLimiter up to Directory and make it IOContext aware MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-4537: ------------------------------------ Attachment: LUCENE-4537.patch here is a new patch detaching RateLimiting entirely from Directory and it's subclasses. RateLimitingDirectoryWrapper creates an IndexOutput wrapper if it knows of a Ratelimiter for the IOContext the IndexOutput is created for. RateLimitingIndexOutput subclasses BufferedIndexOutput and forwards / pauses on flush to the underlying IndexOutput. I also added an optimiztion for a Wrapped BufferedIndexOutput so FSDir uses will have the same experience as they had before just in a cleaner way API wise. > Move RateLimiter up to Directory and make it IOContext aware > ------------------------------------------------------------ > > Key: LUCENE-4537 > URL: https://issues.apache.org/jira/browse/LUCENE-4537 > Project: Lucene - Core > Issue Type: Improvement > Components: core/store > Affects Versions: 4.0 > Reporter: Simon Willnauer > Fix For: 4.1, 5.0 > > Attachments: LUCENE-4537.patch, LUCENE-4537.patch, LUCENE-4537.patch, LUCENE-4537.patch > > > Currently the RateLimiter only applies to FSDirectory which is fine in general but always requires casts and other dir. impls (custom ones could benefit from this too.) We are also only able to rate limit merge operations which limits the functionality here a lot. Since we have the context information what the IndexOutput is used for we can use that for rate limiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org