lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <>
Subject Re: Facet examples javadoc missing in 4.0?
Date Sat, 24 Nov 2012 18:26:31 GMT
On Sat, Nov 24, 2012 at 9:18 AM, Shai Erera <> wrote:

> We tried that in LUCENE-3998 without success. The problem are facet tests
> which depend on data that exists in the example package. I don't want to
> disable tests just for the sake of separation, nor move to the examples
> package tests that should reside in the module itself.
I don't get this: the demo module does have tests already.

If the demo module includes faceting examples, why wouldnt we move the
tests there as well?

In other words, we should have a clean separation of unit testing the code
versus testing the examples.

View raw message