lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <>
Subject Re: Facet examples javadoc missing in 4.0?
Date Sat, 24 Nov 2012 17:18:17 GMT
bq. I don't think we should do this.

Why? What's the harm? It's a fairly simple fix to the build.xml and it's
not like all other modules have example code under demo, such that the
facet one stands out.

bq. Can we merge these examples into the demo/ module?

We tried that in LUCENE-3998 without success. The problem are facet tests
which depend on data that exists in the example package. I don't want to
disable tests just for the sake of separation, nor move to the examples
package tests that should reside in the module itself.

I don't think that it's easy to make this separation currently, but we can
discuss it more on the issue. I created a patch then with my attempts,
which were no successful, I'll try to find it.

In the meantime, I want to fix the build.xml. If we'll ever move examples
under demo, we'll notice it right away (the build won't find the
src/examples dir under facet) and we can remove the inlining of

Or, we just open up the possibility for that macro to take additional
packages, but I don't know how to do that. I tried to define <sources> in
facet/build.xml, but it didn't like it ...


On Sat, Nov 24, 2012 at 3:28 PM, Robert Muir <> wrote:

> On Sat, Nov 24, 2012 at 2:13 AM, Shai Erera <> wrote:
>> Hi
>> I noticed that the javadocs for the facet module do not exist in 4.0. In
>> the past, the facet/build.xml contains a <javadoc> tag with these packages:
>>           <packageset dir="${src.dir}"/>
>>           <packageset dir="${examples.dir}"/>
>> It seems that with the refactoring of the modules-javadocs build system,
>> they were removed and now every module contains only the "src.dir"
>> packageset.
>> I didn't find a clean way to add another package source to the facet
>> javadocs, besides overriding <javadocs> and inline <invoke-javadoc-module>,
>> to add another packagset.
>> Is that indeed the best approach, or can <invoke-javadoc-module> be
>> extended to support additional sources?
> I don't think we should do this.
> Can we merge these examples into the demo/ module?
> Otherwise lets make a facet-examples module, if it wants to have its own
> jar/javadocs/etc.

View raw message