lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4539) DocValues impls should read all headers up-front instead of per-directsource
Date Tue, 06 Nov 2012 15:24:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491520#comment-13491520
] 

Adrien Grand commented on LUCENE-4539:
--------------------------------------

bq. Who is keeping up with all the places that must be managed when a packed ints version
change needs to happen?

Sorry I was not clear: I didn't mean to remove the version number, just the codec name. I
think the Lucene41 postings format is a good example: it never writes "PackedInts" in the
stream, writes the PackedInts version at the beginning of the stream and may then serialize
thousands arrays of 128 values with the number of bits per value as a byte in front of each
of them.
                
> DocValues impls should read all headers up-front instead of per-directsource
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-4539
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4539
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Robert Muir
>         Attachments: LUCENE-4539.patch
>
>
> Currently, when DocValues opens, it just opens files. it doesnt read codec headers etc.
> Instead we read these every single time a directsource opens. 
> I think it should work like PostingsReaders: e.g. the PackedInts impl would read its
versioning info and codec headers and creating a new Direct impl should be a IndexInput.clone()
+ getDirectReaderNoHeader().
> Today its much more costly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message