lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3441) Add NRT support to LuceneTaxonomyReader
Date Tue, 20 Nov 2012 11:38:58 GMT


Michael McCandless commented on LUCENE-3441:

bq. Since the usage of openIfChanged is well defined, and assuming that people who interact
with the taxonomy are aware Lucen's NRT, should we rely on the old taxo reader instances to
not be used after openIfChanged?

Hmm, for NRT the old reader should continue working just fine even if a new reader was openIfChange'd
off of it.  EG there may be queries in-flight still against the old reader.

However, for TR, would the old TR ever receive a request to look up an out-of-bounds ord?
 It shouldn't, right?  Can we declare that the results when you pass out of bounds ords are
not defined, ie that's abuse of the API?
> Add NRT support to LuceneTaxonomyReader
> ---------------------------------------
>                 Key: LUCENE-3441
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-3441.patch
> Currently LuceneTaxonomyReader does not support NRT - i.e., on changes to LuceneTaxonomyWriter,
you cannot have the reader updated, like IndexReader/Writer. In order to do that we need to
do the following:
> # Add ctor to LuceneTaxonomyReader to allow you to instantiate it with LuceneTaxonomyWriter.
> # Add API to LuceneTaxonomyWriter to expose its internal IndexReader
> # Change LTR.refresh() to return an LTR, rather than void. This is actually not strictly
related to that issue, but since we'll need to modify refresh() impl, I think it'll be good
to change its API as well. Since all of facet API is @lucene.experimental, no backwards issues
here (and the sooner we do it, the better).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message