lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Po Rui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4071) CollectionsHandler.handleCreateAction() doesn't validate parameter count and type
Date Thu, 15 Nov 2012 09:50:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497881#comment-13497881
] 

Po Rui commented on SOLR-4071:
------------------------------

yes. the null object got by SolrQueryRequest.getParams().get() will write into ZkNodeProps
as a String "null" in Handler. e.g. request:http://127.0.0.1:8983/solr/admin/collections?action=CREATE&name=collection2&numShards=3&numReplicas=2.
this request miss parameter 'collection.configName'. but the finally message offer to distributed
queue(/overseer/queque) like

{……
name : collection2;
numShards : 3;
collection.configName : null;
……
}
the String 'null' become the default value. all other args in any message maybe potentially
assigned to value "null"
                
> CollectionsHandler.handleCreateAction() doesn't validate parameter count and type
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4071
>                 URL: https://issues.apache.org/jira/browse/SOLR-4071
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-BETA, 4.0
>            Reporter: Po Rui
>            Assignee: Mark Miller
>            Priority: Critical
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-4071.patch
>
>
> CollectionsHandler.handleCreateAction() doesn't validate parameter count and type. numShards's
type doesn't checked and parameter count maybe less than required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message