lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4515) Make MemoryIndex more memory efficient
Date Thu, 01 Nov 2012 13:25:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488684#comment-13488684
] 

Robert Muir commented on LUCENE-4515:
-------------------------------------

I have two concerns:
1. the passing of allocators to public classes (Mike's concern). Why cant we just have a method
like reset()? This is way cleaner, the datastructure is no longer exposed.
2. the whole idea that this is "expert". e.g. highlighting isnt fast unless you use crazy
apis that only ES/Solr use. This just makes lucene less useable as a whole. Instead of hacking
around the highlighter here with BlockPoolAllocators: we should fix the highlighter to work
well by default. e.g. it should have a sugar method like highlight(TopDocs) that uses MemoryIndex.reset()
behind the scenes. This would be a simple and easy method for anyone to use.



                
> Make MemoryIndex more memory efficient
> --------------------------------------
>
>                 Key: LUCENE-4515
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4515
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 4.0, 4.1, 5.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4515.patch, LUCENE-4515.patch
>
>
> Currently MemoryIndex uses BytesRef objects to represent terms and holds an int[] per
term per field to represent postings. For highlighting this creates a ton of objects for each
search that 1. need to be GCed and 2. can't be reused.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message