lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Gossé (JIRA) <j...@apache.org>
Subject [jira] [Created] (SOLR-4107) Parse Error message lost from 3.5.0 to 3.6.1
Date Thu, 22 Nov 2012 11:40:58 GMT
Pierre Gossé created SOLR-4107:
----------------------------------

             Summary: Parse Error message lost from 3.5.0 to 3.6.1
                 Key: SOLR-4107
                 URL: https://issues.apache.org/jira/browse/SOLR-4107
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 3.6.1
            Reporter: Pierre Gossé
            Priority: Minor


QueryComponent.prepare builds a SolrException from ParseException encountered, using a constructor
that forces error message to null

in 3.5.0
public SolrException(ErrorCode code, Throwable th) {
   super(th);
   this.code=code.code;
   logged=true;
}


in 3.6.1 :
public SolrException(ErrorCode code, Throwable th) {
   this(code, null, th, (th instanceof SolrException) ? ((SolrException)th).logged : false);
}
calling :
public SolrException(ErrorCode code, String msg, Throwable th, boolean alreadyLogged) {
   super(msg,th);
   this.code=code.code;
   logged=alreadyLogged;
}

I don't think this is a desired behaviour, so I guessed this should be corrected by changing
line 93 to 
   this(code, th.getMessage(), th, (th instanceof SolrException) ?(SolrException)th).logged
: false);

I'll try to add a patch later today.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message