lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-4526) Allow runtime settings on Codecs
Date Fri, 02 Nov 2012 15:53:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489501#comment-13489501
] 

Robert Muir edited comment on LUCENE-4526 at 11/2/12 3:53 PM:
--------------------------------------------------------------

I just glanced through in general: this is similar to the hack patch i used exploring LUCENE-4089,
though I just used a Map<String,String>.

The part i didnt like when exploring was more related to how term index/term dictionary are
separated:
{quote}
divisor: generalize this into something simple like a Map<String,String> of codec "parameters"
that you set on IWC/IR. split divisor from "don't load terms index". define these as constants
where they belong. I got unhappy here in the "splitting" part because I wanted the divisor
part in TermsIndexReaderBase, but that doesnt extend FieldsProducer (where i wanted the "don't
load" part) and wrap the terms dict, instead its backwards and terms dict wraps the TermsIndexReaderBase...
maybe we should fix that too? I think this confusing the way it is but I didnt look at how
difficult this would be.
{quote}

But I think maybe I was trying to tackle too much at once... still as an "untyped" parameter
I thought it would be useful to fix the semantics all in one break rather than causing confusion
down the road.

                
      was (Author: rcmuir):
    I just glanced through in general: this is similar to the hack patch i used exploring
LUCENE-4089, though I just used a Map<String,String>.

The part i didnt like when exploring was more related to how term index/term dictionary are
separated:
{noformat}
divisor: generalize this into something simple like a Map<String,String> of codec "parameters"
that you set on IWC/IR. split divisor from "don't load terms index". define these as constants
where they belong. I got unhappy here in the "splitting" part because I wanted the divisor
part in TermsIndexReaderBase, but that doesnt extend FieldsProducer (where i wanted the "don't
load" part) and wrap the terms dict, instead its backwards and terms dict wraps the TermsIndexReaderBase...
maybe we should fix that too? I think this confusing the way it is but I didnt look at how
difficult this would be.
{noformat}

But I think maybe I was trying to tackle too much at once... still as an "untyped" parameter
I thought it would be useful to fix the semantics all in one break rather than causing confusion
down the road.

                  
> Allow runtime settings on Codecs
> --------------------------------
>
>                 Key: LUCENE-4526
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4526
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4526.patch
>
>
> Today we expose termIndexInterval and termIndexDivisor via several APIs and they are
deprecated. Those settings are 1. codec / postingformat specific and 2. not extendable. We
should provide a more flexible way to pass information down to our codecs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message