lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karsten R. (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2438) Case Insensitive Search for Wildcard Queries
Date Thu, 22 Nov 2012 15:17:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502816#comment-13502816
] 

Karsten R. commented on SOLR-2438:
----------------------------------

Hi Erick,

in your commit Revision 1206767 (2011-11-27) there is a change in
org.apache.solr.search.SolrQueryParser#getReversedWildcardFilterFactory(FieldType)
Before this commit the Map leadingWildcards was important, after this the Map leadingWildcards
is only a cache. A cache, which is never used:
{code}
ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
if (fac == null && leadingWildcards.containsKey(fac)) {
   return fac;
}
{code}
If we want to use this cache it should be
{code}
ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
if (fac != null || leadingWildcards.containsKey(fieldType)) {
   return fac;
}
{code}

best regards
  Karsten


                
> Case Insensitive Search for Wildcard Queries
> --------------------------------------------
>
>                 Key: SOLR-2438
>                 URL: https://issues.apache.org/jira/browse/SOLR-2438
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Peter Sturge
>            Assignee: Erick Erickson
>             Fix For: 3.6, 4.0-ALPHA
>
>         Attachments: SOLR-2438_3x.patch, SOLR-2438-3x.patch, SOLR-2438-3x.patch, SOLR-2438.patch,
SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
SOLR-2438.patch, SOLR-2438.patch
>
>
> This patch adds support to allow case-insensitive queries on wildcard searches for configured
TextField field types.
> This patch extends the excellent work done Yonik and Michael in SOLR-219.
> The approach here is different enough (imho) to warrant a separate JIRA issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message