lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4575) Allow IndexWriter to commit, even just commitData
Date Thu, 29 Nov 2012 13:32:58 GMT


Shai Erera commented on LUCENE-4575:

Thanks. I forgot to mention two things about the changes in the patch, which I wasn't sure

# I currently copy the commitData map on setCommitData. It seems safe to do it, and I don't
think commitData are huge. Any objections?
# I set pass the copied map directly to segmentInfos, rather than saving it in a member in
IW. Do you see any issues with it? (I'm thinking about rollback, even though we have another
copy of the segmentInfos for rollback purposes ...)
> Allow IndexWriter to commit, even just commitData
> -------------------------------------------------
>                 Key: LUCENE-4575
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4575.patch
> Spinoff from here
> In some cases, it is valuable to be able to commit changes to the index, even if the
changes are just commitData. Such data is sometimes used by applications to register in the
index some global application information/state.
> The proposal is:
> * Add a setCommitData() API and separate it from commit() and prepareCommit() (simplify
their API)
> * When that API is called, flip on the dirty/changes bit, so that this gets committed
even if no other changes were made to the index.
> I will work on a patch a post.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message