lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4537) Move RateLimiter up to Directory and make it IOContext aware
Date Mon, 05 Nov 2012 12:42:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490599#comment-13490599
] 

Robert Muir commented on LUCENE-4537:
-------------------------------------

Actually I don't think we should do this: here's my line of reasoning.

Instead of dictacting data structures and maps in this abstract class,
really, we should just have abstract methods.

But we already have these! they are createOutput/openInput!

Anything else is unnecessary bloat here.
                
> Move RateLimiter up to Directory and make it IOContext aware
> ------------------------------------------------------------
>
>                 Key: LUCENE-4537
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4537
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4537.patch
>
>
> Currently the RateLimiter only applies to FSDirectory which is fine in general but always
requires casts and other dir. impls (custom ones could benefit from this too.) We are also
only able to rate limit merge operations which limits the functionality here a lot. Since
we have the context information what the IndexOutput is used for we can use that for rate
limiting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message