lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominik Siebel (JIRA)" <>
Subject [jira] [Commented] (SOLR-4110) Configurable Content-Type headers for PHPResponseWriters and PHPSerializedResponseWriter
Date Thu, 29 Nov 2012 07:40:58 GMT


Dominik Siebel commented on SOLR-4110:

Upgrading from 4.0?

I don't see any harm in the ResponseWriters being configurable. JSONResponseWriter already
is (as far as Content-Type header in concerned).
Sending _text/x-php;charset=UTF-8_ as default however might be an issue, yes (if anyone really
relies on text/plain for PHP and PHPs).
But since the Content-Type header of the ResponseWriters would be configurable you could still
overwrite the defaults in _solrconfig.xml_ just like the example does with the _JSONResponseWriter_:

{code xml}
<queryResponseWriter name="json" class="solr.JSONResponseWriter">
	<!-- For the purposes of the tutorial, JSON responses are written as
	  plain text so that they are easy to read in *any* browser.
	  If you expect a MIME type of "application/json" just remove this override.
	<str name="content-type">text/plain; charset=UTF-8</str>
> Configurable Content-Type headers for PHPResponseWriters and PHPSerializedResponseWriter
> ----------------------------------------------------------------------------------------
>                 Key: SOLR-4110
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 4.0
>            Reporter: Dominik Siebel
>            Assignee: Mark Miller
>            Priority: Minor
>              Labels: 4.0.1_Candidate
>             Fix For: 4.1, 5.0
>         Attachments: SOLR-4110.patch
> The *PHPResponseWriter* and *PHPSerializedResponseWriter* currently send a hard coded
Content-Type header of _text/plain; charset=UTF-8_ although there are constants defining _text/x-php;charset=UTF-8_
and _text/x-php-serialized;charset=UTF-8_ which remain unused. This makes content type guessing
on the client side quite complicated.
> I already created a patch (from the branch_4x github branch) to use the respective constants
and also added the possibility to configure the Content-Type header via solrconfig.xml (like
in JSONResponseWriter).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message