lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4519) IndexDocument methods should not use wildcards in their return types
Date Sun, 04 Nov 2012 12:16:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490177#comment-13490177
] 

Uwe Schindler commented on LUCENE-4519:
---------------------------------------

Can you add javadocs to FilterIterator, so the generics are more clear. It is confusing which
one is the inner iterator's type and which one the outer's. I would propose to rename the
params to be more clear, too. Like FilterIterator<T, InnerT>.
                
> IndexDocument methods should not use wildcards in their return types
> --------------------------------------------------------------------
>
>                 Key: LUCENE-4519
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4519
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>         Attachments: LUCENE-4519.patch
>
>
> {{public Iterable<? extends IndexableField> indexableFields()}} should be replaced
with {{public Iterable<IndexableField> indexableFields()}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message