lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4537) Move RateLimiter up to Directory and make it IOContext aware
Date Mon, 05 Nov 2012 12:56:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490604#comment-13490604
] 

Robert Muir commented on LUCENE-4537:
-------------------------------------

Its absolutely reasonable. Otherwise the APIs are broken here.

putting this concrete map on an abstract class that does nothing with it: thats not going
to happen here.

Lets fix the real bug: that rate limiting isnt just wrapping with a different IO impl! Then
the original
directory factory apis work fine with it: if you want a concurrent map you can manage this
all yourself.

If we want a sugar "RateLimitingDirectoryWrapper" thats fine. But its bogus this shit is in
FSDir today.
                
> Move RateLimiter up to Directory and make it IOContext aware
> ------------------------------------------------------------
>
>                 Key: LUCENE-4537
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4537
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4537.patch, LUCENE-4537.patch
>
>
> Currently the RateLimiter only applies to FSDirectory which is fine in general but always
requires casts and other dir. impls (custom ones could benefit from this too.) We are also
only able to rate limit merge operations which limits the functionality here a lot. Since
we have the context information what the IndexOutput is used for we can use that for rate
limiting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message