lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <>
Subject [jira] [Commented] (SOLR-1916) investigate DIH use of default locale
Date Mon, 26 Nov 2012 21:47:03 GMT


Commit Tag Bot commented on SOLR-1916:

[trunk commit] James Dyer

SOLR-1916: reinstate @Ignore'ed test

> investigate DIH use of default locale
> -------------------------------------
>                 Key: SOLR-1916
>                 URL:
>             Project: Solr
>          Issue Type: Task
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.1, 4.0-ALPHA
>            Reporter: Robert Muir
>            Assignee: James Dyer
>             Fix For: 4.1, 5.0
>         Attachments: SOLR-1916.patch, SOLR-1916.patch
> This is a spinoff from LUCENE-2466.
> In this issue I changed my locale to various locales and found some problems in Lucene/Solr
triggered by use of the default Locale.
> I noticed some use of the default-locale for Date operations in DIH (TimeZone.getDefault/Locale.getDefault)
and, while no tests fail, I think it might be better to support a locale parameter for this.
> The wiki documents that numeric parsing can support localized numerics formats:
> In both cases, I don't think we should ever use the default Locale. If no Locale is provided,
I find that new Locale("") <-- Unicode Root Locale, is a better default for a server situation
in a lot of cases, as it won't change depending on the computer, or perhaps we just make Locale
params mandatory for this.
> Finally, in both cases, if localized numbers/dates are explicitly supported, I think
we should come up with a test strategy to ensure everything is working. One idea is to do
something similar to or make use of Lucene's LocalizedTestCase.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message