lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4537) Move RateLimiter up to Directory and make it IOContext aware
Date Tue, 06 Nov 2012 09:40:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491345#comment-13491345
] 

Simon Willnauer commented on LUCENE-4537:
-----------------------------------------

bq. I think this is some premature optimization.
I am not sure if that is premature. But I do agree it would be great if we could just wrap
the IndexOutput to do this kind of stuff entirely outside of Directory. Maybe we can have
a flush callback on BufferedIndexOutput we can hook into the flush call. This would also enable
us to do some flush statistics which is independent of this issue. This could be an impl detail
of BufferedIndexOutput but it would enable us to 1. do the opto we do today 2. divorce the
rate limiting entirely from Dir.
                
> Move RateLimiter up to Directory and make it IOContext aware
> ------------------------------------------------------------
>
>                 Key: LUCENE-4537
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4537
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4537.patch, LUCENE-4537.patch, LUCENE-4537.patch
>
>
> Currently the RateLimiter only applies to FSDirectory which is fine in general but always
requires casts and other dir. impls (custom ones could benefit from this too.) We are also
only able to rate limit merge operations which limits the functionality here a lot. Since
we have the context information what the IndexOutput is used for we can use that for rate
limiting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message