Eirik Lygre created SOLR-4081:
---------------------------------
Summary: QueryParsing.toString(Query,IndexSchema) does not properly handle WrappedQuery
Key: SOLR-4081
URL: https://issues.apache.org/jira/browse/SOLR-4081
Project: Solr
Issue Type: Bug
Components: query parsers
Affects Versions: 4.0
Reporter: Eirik Lygre
Priority: Minor
QueryParsing.toString() is a method that uses knowledge of various Query implementations to
properly render a query string. For example, using toString with a BooleanQuery might return
a string like this:
{{owner_id:18935 (acl_id:9451 acl_id:11634 acl_id:15678 acl_id:16791)}}
When using localParams such as "{!cache=false cost=0}", the query turns into a WrappedQuery
wrapping a BooleanQuery. This is not understood by QueryParsing.toString(), which calls WrappedQuery.toString()
instead, returning a string like this:
{{\{!cache=false cost=0}owner_id:w (acl_id:` acl_id:Ik acl_id:Zr acl_id:z> acl_id:\)}}
The probable (untested) solution will be to include a couple of lines at the top of toString(),
as shown below. A further optimization would be to create "void WrappedQuery.getOptions(Appendable
out)", to avoid creating a StringBuilder inside WrappedQuery.getOptions().
{code}
public static void toString(Query query, IndexSchema schema, Appendable out, int flags) throws
IOException {
boolean writeBoost = true;
// Begin new code to handle WrappedQuery
if (query instanceof WrappedQuery) {
WrappedQuery q = (WrappedQuery)query;
out.append (q.getOptions());
query = q.getWrappedQuery();
}
// End new code to handle WrappedQuery
if (query instanceof TermQuery) {
...
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
|