lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sivan Yogev (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3441) Add NRT support to LuceneTaxonomyReader
Date Tue, 20 Nov 2012 10:00:58 GMT


Sivan Yogev commented on LUCENE-3441:

Went through the patch and it looks good. 

One symmetry question I have - TR is now abstract class and TW still interface. Can it be
that we should make TW also abstract class?

A few minor comments:

* constructors are public but have no Javadoc. Are they meant for external (outside the taxonomy
package) usage? 

* Semi-cosmetic issue - I would move the first (non-public) constructor after the two public
ones, confused me a bit to see that one first. 
* Line 127: unnecessary "to" in Javadoc of param directory.
* 4000 appears 4 times in the code, would rather have it once as a constant.

> Add NRT support to LuceneTaxonomyReader
> ---------------------------------------
>                 Key: LUCENE-3441
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-3441.patch
> Currently LuceneTaxonomyReader does not support NRT - i.e., on changes to LuceneTaxonomyWriter,
you cannot have the reader updated, like IndexReader/Writer. In order to do that we need to
do the following:
> # Add ctor to LuceneTaxonomyReader to allow you to instantiate it with LuceneTaxonomyWriter.
> # Add API to LuceneTaxonomyWriter to expose its internal IndexReader
> # Change LTR.refresh() to return an LTR, rather than void. This is actually not strictly
related to that issue, but since we'll need to modify refresh() impl, I think it'll be good
to change its API as well. Since all of facet API is @lucene.experimental, no backwards issues
here (and the sooner we do it, the better).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message